heesung-sn commented on code in PR #21906:
URL: https://github.com/apache/pulsar/pull/21906#discussion_r1477439085
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/UniformLoadShedder.java:
##########
@@ -154,8 +154,7 @@ public Multimap<String, String>
findBundlesForUnloading(final LoadData loadData,
}
String bundle = e.getLeft();
double bundleMsgRate = e.getRight();
- if (bundleMsgRate <=
(msgRateRequiredFromUnloadedBundles.getValue()
- + 1000/* delta */)) {
Review Comment:
I see. Plz update the motivation in the description that this
threshold(delta) can be controlled by minUnloadMessage and
minUnloadMessageThroughput. Hence , keeping this delta is redundant and error
prone for the smaller traffic too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
