Technoboy- commented on code in PR #22022:
URL: https://github.com/apache/pulsar/pull/22022#discussion_r1477344085
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1779,10 +1779,14 @@ private CompletableFuture<ManagedLedgerConfig>
getManagedLedgerConfig(@Nonnull T
}
if (retentionPolicies == null) {
- retentionPolicies = policies.map(p ->
p.retention_policies).orElseGet(
- () -> new
RetentionPolicies(serviceConfig.getDefaultRetentionTimeInMinutes(),
- serviceConfig.getDefaultRetentionSizeInMB())
- );
+ if (SystemTopicNames.isSystemTopic(topicName)) {
+ retentionPolicies = new RetentionPolicies(0, 0);
Review Comment:
It is better to add a log here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
