codelipenghui commented on code in PR #22022:
URL: https://github.com/apache/pulsar/pull/22022#discussion_r1477629496


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1779,10 +1779,18 @@ private CompletableFuture<ManagedLedgerConfig> 
getManagedLedgerConfig(@Nonnull T
             }
 
             if (retentionPolicies == null) {
-                retentionPolicies = policies.map(p -> 
p.retention_policies).orElseGet(
-                        () -> new 
RetentionPolicies(serviceConfig.getDefaultRetentionTimeInMinutes(),
-                                serviceConfig.getDefaultRetentionSizeInMB())
-                );
+                if (SystemTopicNames.isSystemTopic(topicName)) {
+                    if (log.isDebugEnabled()) {
+                        log.debug("{} The retention policies of system topics 
cannot be overridden by the namespace "
+                                + "or broker policies.", topicName);

Review Comment:
   ```suggestion
                           log.debug("{} Disable data retention policy for 
system topic.", topicName);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to