gaoran10 commented on code in PR #22025:
URL: https://github.com/apache/pulsar/pull/22025#discussion_r1478480573
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicListService.java:
##########
@@ -59,9 +65,12 @@ public List<String> getMatchingTopics() {
return matchingTopics;
}
+ /***
+ * @param topicName topic name which contains partition suffix.
+ */
@Override
public void accept(String topicName, NotificationType
notificationType) {
- if (topicsPattern.matcher(topicName).matches()) {
+ if
(topicsPattern.matcher(TopicName.get(topicName).getPartitionedTopicName()).matches())
{
Review Comment:
Could we check both the partitioned topic name and the topic name with the
partition suffix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
