poorbarcode commented on code in PR #22025:
URL: https://github.com/apache/pulsar/pull/22025#discussion_r1483784690
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicListService.java:
##########
@@ -59,9 +65,12 @@ public List<String> getMatchingTopics() {
return matchingTopics;
}
+ /***
+ * @param topicName topic name which contains partition suffix.
+ */
@Override
public void accept(String topicName, NotificationType
notificationType) {
- if (topicsPattern.matcher(topicName).matches()) {
+ if
(topicsPattern.matcher(TopicName.get(topicName).getPartitionedTopicName()).matches())
{
Review Comment:
@gaoran10 Ah, you means return `true` whether `{tenant}/{ns}/{tp}` is
matches or `{tenant}/{ns}/{tp}-{partition}` is matches. Good point. We can
submit a new PIP to do this(it is a behavior change)
This PR is in order to revet the behavior as the original behavior before
[PIP-145](https://github.com/apache/pulsar/issues/14505)(it did a break change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
