dragosvictor commented on code in PR #22048:
URL: https://github.com/apache/pulsar/pull/22048#discussion_r1486973639


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -298,6 +299,12 @@ public synchronized void start() throws 
PulsarServerException {
 
             ExtensibleLoadManagerImpl.createSystemTopic(pulsar, TOPIC);
 
+            Long threshold = 
pulsar.getAdminClient().topicPolicies().getCompactionThreshold(TOPIC);
+            if (threshold == null || COMPACTION_THRESHOLD != threshold) {
+                
pulsar.getAdminClient().topicPolicies().setCompactionThreshold(TOPIC, 
COMPACTION_THRESHOLD);
+                log.info("Set compaction threshold for system topic {}.", 
TOPIC);
+            }

Review Comment:
   Is there a way to override this only if there's no topic-level policy 
already? Otherwise, this might make it harder to debug/workaround issues in the 
future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to