dragosvictor commented on code in PR #22048:
URL: https://github.com/apache/pulsar/pull/22048#discussion_r1486993884
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -298,6 +299,12 @@ public synchronized void start() throws
PulsarServerException {
ExtensibleLoadManagerImpl.createSystemTopic(pulsar, TOPIC);
+ Long threshold =
pulsar.getAdminClient().topicPolicies().getCompactionThreshold(TOPIC);
+ if (threshold == null || COMPACTION_THRESHOLD != threshold) {
+
pulsar.getAdminClient().topicPolicies().setCompactionThreshold(TOPIC,
COMPACTION_THRESHOLD);
+ log.info("Set compaction threshold for system topic {}.",
TOPIC);
+ }
Review Comment:
I meant, isn't it possible that a topic-level policy has already been set,
and we'd be overriding that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
