merlimat commented on code in PR #22179:
URL: https://github.com/apache/pulsar/pull/22179#discussion_r1511767392
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -258,11 +270,17 @@ public ClientCnx(ClientConfigurationData conf,
EventLoopGroup eventLoopGroup, in
this.idleState = new ClientCnxIdleState(this);
this.clientVersion = "Pulsar-Java-v" + PulsarVersion.getVersion()
+ (conf.getDescription() == null ? "" : ("-" +
conf.getDescription()));
+ this.connectionsOpenedCounter =
instrumentProvider.newCounter("pulsar.client.connections.opened",
Unit.Connections,
+ "Counter of connections opened", Attributes.empty());
+ this.connectionsClosedCounter =
instrumentProvider.newCounter("pulsar.client.connections.closed",
Unit.Connections,
Review Comment:
I don't think these are going to be interesting. As in: there was never a
moment in which I'd have said that I really needed that information. I'd leave
it out, at least for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
