merlimat commented on code in PR #22179:
URL: https://github.com/apache/pulsar/pull/22179#discussion_r1511859164


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -268,6 +283,23 @@ public ProducerImpl(PulsarClientImpl client, String topic, 
ProducerConfiguration
             metadata = Collections.unmodifiableMap(new 
HashMap<>(conf.getProperties()));
         }
 
+        InstrumentProvider ip = client.instrumentProvider();
+        Attributes attrs = ip.getAttributes(topic);
+        latencyHistogram = 
ip.newLatencyHistogram("pulsar.client.producer.latency",
+                "Publish latency experienced by the application, includes 
client batching time", attrs);
+        rpcLatencyHistogram = 
ip.newLatencyHistogram("pulsar.client.producer.rpc.latency",
+                "Publish RPC latency experienced internally by the client when 
sending data to receiving an ack", attrs);
+        publishedBytesCounter = 
ip.newCounter("pulsar.client.producer.published",

Review Comment:
   Renaming to `pulsar.client.producer.message.send.size`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to