asafm commented on code in PR #22179:
URL: https://github.com/apache/pulsar/pull/22179#discussion_r1515708519
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java:
##########
@@ -84,6 +92,21 @@ public BinaryProtoLookupService(PulsarClientImpl client,
this.serviceNameResolver = new PulsarServiceNameResolver();
this.listenerName = listenerName;
updateServiceUrl(serviceUrl);
+
+ Attributes attrs =
Attributes.of(AttributeKey.stringKey("transport-type"), "binary");
+
+ histoGetBroker =
client.instrumentProvider().newLatencyHistogram("pulsar.client.lookup",
+ "Lookup operations",
+ attrs.toBuilder().put("type", "topic").build());
Review Comment:
Yes, but from the point of view of the user, he doesn't know about
`LookupService`. They probably know there is binary protocol, and methods
(commands) activated from the client. Only developers would know about
`LookupService`, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
