merlimat commented on code in PR #22179:
URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513094996
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java:
##########
@@ -84,6 +92,21 @@ public BinaryProtoLookupService(PulsarClientImpl client,
this.serviceNameResolver = new PulsarServiceNameResolver();
this.listenerName = listenerName;
updateServiceUrl(serviceUrl);
+
+ Attributes attrs =
Attributes.of(AttributeKey.stringKey("transport-type"), "binary");
+
+ histoGetBroker =
client.instrumentProvider().newLatencyHistogram("pulsar.client.lookup",
+ "Lookup operations",
+ attrs.toBuilder().put("type", "topic").build());
+ histoGetTopicMetadata =
client.instrumentProvider().newLatencyHistogram("pulsar.client.lookup",
+ "Lookup operations",
Review Comment:
Yes, it makes sense to have them aggregated together. Later we might add
other types of lookup and we shouldn't need to update all the dashboards each
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
