lhotari commented on PR #22274: URL: https://github.com/apache/pulsar/pull/22274#issuecomment-1999891418
I provided my feedback on the mailing list https://lists.apache.org/thread/xdq62jytxxj421vly6qzn9dn8vvjqyv1 > Before making this change, I hope that there could be discussion about > improving the configuration solution in Pulsar. > The mailing list thread is > https://lists.apache.org/thread/8splwyrn25pt5rb6ph0yz0tfgknn3hqh . > > With a proper configuration library such as Gestalt Config [1], it's > possible to have a solution that is expressed in this PIP-346. > In Gestalt Config, the feature "Merge Multiple Sources: Seamlessly > merge configurations from different sources to create comprehensive > settings." support this. > > This is the reason why I don't think that we should move forward with > PIP-346 without addressing the proposal in the other mailing list > thread > "[DISCUSSION] Proposal to Replace Pulsar's Homegrown Configuration > Framework with Gestalt Config" [2]. > > -Lari > > 1 - https://github.com/gestalt-config/gestalt#features > 2 - https://lists.apache.org/thread/8splwyrn25pt5rb6ph0yz0tfgknn3hqh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
