Trakina commented on PR #789: URL: https://github.com/apache/pulsar-site/pull/789#issuecomment-2003979300
- [x] Both should have the same font-weight - `400` <img width="843" alt="Screenshot 2024-03-08 at 11 54 24 AM" src="https://github.com/apache/pulsar-site/assets/9302460/a38caed7-9870-4585-8c8c-f5c8019c402a";> <img width="619" alt="Screenshot 2024-03-08 at 11 54 59 AM" src="https://github.com/apache/pulsar-site/assets/9302460/80d1695a-cc17-4204-b6e1-666bf2bf9311";> - [x] Card title should have font-size `22px` (`1.375rem`) <img width="566" alt="Screenshot 2024-03-08 at 11 57 11 AM" src="https://github.com/apache/pulsar-site/assets/9302460/99037f2c-f747-4cc8-8812-f2e1b2ed2077";> - [x] Same font-weight - [x] Number size should be bigger. `64px` vs `96px` - [x] Sentences below the numbers also should have different font-size and font-weight - [x] The `+` in `600+` and `10000+` is an icon with a different size, not the piece of text. - [x] Figma design says that the GitHub number should be a link to https://github/apache/pusar <img width="810" alt="Screenshot 2024-03-08 at 1 13 42 PM" src="https://github.com/apache/pulsar-site/assets/9302460/2667ea5f-999e-47bd-a9f5-0903167e4d56";> <img width="1129" alt="Screenshot 2024-03-08 at 11 58 25 AM" src="https://github.com/apache/pulsar-site/assets/9302460/91c191f8-9a54-440f-b84a-aff3ba0e476f";> - [x] Font weight should be different <img width="445" alt="Screenshot 2024-03-08 at 12 22 02 PM" src="https://github.com/apache/pulsar-site/assets/9302460/b60caa80-2143-4c05-9ae3-3c0ca5d25766";> - [x] Font size should be different <img width="1277" alt="Screenshot 2024-03-08 at 12 23 26 PM" src="https://github.com/apache/pulsar-site/assets/9302460/de826ec6-f3b6-4d8b-b569-9c068db82c00";> - [x] The "Explore docs" button should be white - [x] The text is still not centered vertically. It's because the `<p>` tag has a bottom margin by default. You can just override it for this specific place. <img width="1332" alt="Screenshot 2024-03-08 at 12 24 12 PM" src="https://github.com/apache/pulsar-site/assets/9302460/cb8ecbdd-967e-4e79-bd4b-b6bc944fc6db";> - Font size should be different <img width="437" alt="Screenshot 2024-03-08 at 12 27 28 PM" src="https://github.com/apache/pulsar-site/assets/9302460/4083ac2a-b787-462f-b47e-ac00e938751a";> - [x] Font size and font-weight should be different <img width="387" alt="Screenshot 2024-03-08 at 12 28 24 PM" src="https://github.com/apache/pulsar-site/assets/9302460/0783110b-4156-4654-b239-8abeacba7d31";> - [x] Arrow icons should be smaller <img width="188" alt="Screenshot 2024-03-08 at 12 30 59 PM" src="https://github.com/apache/pulsar-site/assets/9302460/bec9e527-cfc8-43ca-b667-bf09ee79d687";> <img width="223" alt="Screenshot 2024-03-08 at 12 31 13 PM" src="https://github.com/apache/pulsar-site/assets/9302460/c9c30c02-578f-4359-80b1-c28b3ef687dc";> - [x] Max content width should be smaller <img width="947" alt="Screenshot 2024-03-08 at 12 33 06 PM" src="https://github.com/apache/pulsar-site/assets/9302460/5dd6fd26-5b0e-4c23-853a-4a6339878855";> <img width="809" alt="Screenshot 2024-03-08 at 12 33 16 PM" src="https://github.com/apache/pulsar-site/assets/9302460/a16bfdce-31a8-490d-bc21-ea5abe42aa44";> - [x] The space between the title and the first item should be smaller <img width="449" alt="Screenshot 2024-03-08 at 12 34 04 PM" src="https://github.com/apache/pulsar-site/assets/9302460/7ca39a9b-e812-4b8d-8da5-9f18d09ac127";> <img width="471" alt="Screenshot 2024-03-08 at 12 34 18 PM" src="https://github.com/apache/pulsar-site/assets/9302460/eea068ef-70e4-4c9f-bb00-e68c4d10f129";> - [x] Title should have different font weight <img width="631" alt="Screenshot 2024-03-08 at 12 39 38 PM" src="https://github.com/apache/pulsar-site/assets/9302460/0a8d4a6b-9fc0-4cc4-9ca6-d2149e7c6205";> <img width="518" alt="Screenshot 2024-03-08 at 12 40 25 PM" src="https://github.com/apache/pulsar-site/assets/9302460/3c06b2a3-86e7-4743-9c44-5177fdd6a20b";> - [x] Image size should be bigger. `48px` vs `56px` <img width="163" alt="Screenshot 2024-03-08 at 12 41 28 PM" src="https://github.com/apache/pulsar-site/assets/9302460/77cc36ca-0c24-4de4-9694-6dfd19d69708";> - [x] The vertical space between the text and the button should be a bit smaller <img width="547" alt="Screenshot 2024-03-08 at 12 42 44 PM" src="https://github.com/apache/pulsar-site/assets/9302460/9a1f87c1-a8bb-4e38-a307-17abbb64b7c3";> <img width="534" alt="Screenshot 2024-03-08 at 12 43 24 PM" src="https://github.com/apache/pulsar-site/assets/9302460/05f98b30-bbc3-4f37-a410-e6c162699e18";> - [x] Icons width should be bigger `48px` vs `66px` <img width="128" alt="Screenshot 2024-03-08 at 12 45 26 PM" src="https://github.com/apache/pulsar-site/assets/9302460/fad31d85-8645-4243-a983-dfd5bf849728";> - [x] I suppose it should be a long dash, not dash-dash `--` <img width="420" alt="Screenshot 2024-03-08 at 12 44 38 PM" src="https://github.com/apache/pulsar-site/assets/9302460/e86ce35c-da8e-46c9-ad51-0f05bc6fb321";> - [x] Buttons should be under the whole content, not the part of the first column. <img width="657" alt="Screenshot 2024-03-08 at 12 46 49 PM" src="https://github.com/apache/pulsar-site/assets/9302460/106082a1-ecd7-4056-a783-19428efcf4bc";> <img width="674" alt="Screenshot 2024-03-08 at 12 47 32 PM" src="https://github.com/apache/pulsar-site/assets/9302460/9553c7b4-6cc5-4357-aa28-e1f6a9032799";> - [x] Max content width should be less <img width="1271" alt="Screenshot 2024-03-08 at 12 48 15 PM" src="https://github.com/apache/pulsar-site/assets/9302460/812e366e-6153-44ca-8dbf-e2b3b45b1ea1";> <img width="809" alt="Screenshot 2024-03-08 at 12 48 28 PM" src="https://github.com/apache/pulsar-site/assets/9302460/f53c4d95-fc52-422e-9852-6fc6f26bc294";> - [x] Please recheck font sizes and font weights for this section <img width="688" alt="Screenshot 2024-03-08 at 1 12 16 PM" src="https://github.com/apache/pulsar-site/assets/9302460/baa2c68b-95dc-4cd2-a1f2-489e1a6adc6b";> <img width="816" alt="Screenshot 2024-03-08 at 12 50 13 PM" src="https://github.com/apache/pulsar-site/assets/9302460/7e9f26b9-507c-4ccc-862b-ce056fc47da3";> - [x] Font size and font weight should be different here `16px` vs `18px`, `700` vs `600` <img width="440" alt="Screenshot 2024-03-08 at 12 51 14 PM" src="https://github.com/apache/pulsar-site/assets/9302460/3fea59aa-43b4-4a85-9622-ae11b46b54ff";> - [x] The "Go to GitHub" link shouldn't have underlined. - [x] The horizontal space between links should be bigger <img width="345" alt="Screenshot 2024-03-08 at 12 53 55 PM" src="https://github.com/apache/pulsar-site/assets/9302460/5281b972-fc34-458e-9a65-95d428eec0b3";> <img width="313" alt="Screenshot 2024-03-08 at 12 54 51 PM" src="https://github.com/apache/pulsar-site/assets/9302460/5ae03e7e-0f06-444a-894e-6b3e0e991084";> - [x] The "Blog" font-weight should be `600`, not `700` - [x] The height of this block should be `96px`, not `144px` <img width="1379" alt="Screenshot 2024-03-08 at 12 56 27 PM" src="https://github.com/apache/pulsar-site/assets/9302460/e5bb80cb-fee5-416f-b1cf-b653ced160a8";> - [x] The order should be different. Title, author, date. The author should be bold. <img width="335" alt="Screenshot 2024-03-08 at 12 58 30 PM" src="https://github.com/apache/pulsar-site/assets/9302460/05da2b5a-46b4-4c88-9df1-58969dd4329c";> <img width="354" alt="Screenshot 2024-03-08 at 12 58 42 PM" src="https://github.com/apache/pulsar-site/assets/9302460/b243bde0-aa46-4e08-a73f-56255b101d2f";> - [x] Font size and font weight should be different <img width="787" alt="Screenshot 2024-03-08 at 1 01 13 PM" src="https://github.com/apache/pulsar-site/assets/9302460/3894b435-dc7c-4a8b-a36a-b1b44bf2592d";> <img width="677" alt="Screenshot 2024-03-08 at 1 01 20 PM" src="https://github.com/apache/pulsar-site/assets/9302460/8dff285d-3fed-4c52-a6d2-6c853703906c";> - [x] The "read" link shouldn't be bold - [x] The "read" link arrow icon should be different <img width="806" alt="Screenshot 2024-03-08 at 1 02 01 PM" src="https://github.com/apache/pulsar-site/assets/9302460/43ee3283-f497-4e5a-becf-d280c857fe02";> <img width="514" alt="Screenshot 2024-03-08 at 1 02 19 PM" src="https://github.com/apache/pulsar-site/assets/9302460/c716189c-04cf-42ea-a2d9-7a1afb6c6da3";> - [x] The order should be different. Title, author, date. The author should be bold. <img width="582" alt="Screenshot 2024-03-08 at 1 02 51 PM" src="https://github.com/apache/pulsar-site/assets/9302460/353f5ab2-a265-4978-b4c0-9c00fa722fa9";> --- - [x] Please resolve the merge conflicts. Pay attention to the new `LandingPage` class. Docs and other page font sizes are different now. Please apply it for all the pages you worked on. https://github.com/apache/pulsar-site/blob/b2a3d6d28a9911dcfb6914df9e5c5dcdcd7c27b3/src/components/pages/HomePage/HomePage.tsx#L17 - [x] Take the /case-studies page from the `main` branch. I updated the page according to the design and updated all company logos to make them look crisp. https://pulsar.apache.org/case-studies/ https://pulsar-site-2024-updates.vercel.app/case-studies I forgot to add this section for mobile. I'll copy-paste it from your commits later. @visortelle I just copied the new images and updated the header styles. The rest of it wasn't on Figma, so I did not do it. <img width="604" alt="Screenshot 2024-03-08 at 12 10 50 PM" src="https://github.com/apache/pulsar-site/assets/9302460/282a6566-9a1f-4d44-a87e-5d310a5e9bf9";> --- I didn't re-check on the mobile and tablet. I think it's enough to fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
