Re: [PR] [improve/feat][site] Layout and content updates to Homepage, Features, Community, Events, Books and Blog, Added Use Cases Page. Resources are split into Articles and Presentations Pages. [pulsar-site]

[via GitHub]

Trakina commented on PR #789:
URL: https://github.com/apache/pulsar-site/pull/789#issuecomment-1983652714

   > @asafm ok ;)
   > 
   > Then I have a few more comments for the "Community Page":
   > 
   >     * [ ]  Discussion section items title should use bold font
   > 
   >     * [ ]  The order of discussion channels is different in Figma.
   > 
   >     * [ ]  The font size should be smaller: 18px vs 24px
   > 
   > 
   > **Design** <img alt="Screenshot 2024-02-24 at 5 42 47 PM" width="1308" 
src="https://private-user-images.githubusercontent.com/9302460/307525824-efdf54ca-4329-4db4-892a-26d16ed87bc5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNTgyNC1lZmRmNTRjYS00MzI5LTRkYjQtODkyYS0yNmQxNmVkODdiYzUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODAxZjg5M2I5ZGJmZDA3YjQzMjY4YTlkOTE0ODEzZmM1N2M2ZDc3Mzk4MDcxNzMzZGI1MGYwMmE0ZGFjOGE3MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.V1IthRuEgWxUsQ6k_UC73sxVBaQr8k4nsWDG5FoL3_o";>
   > 
   > **Implementation**
   > <img alt="Screenshot 2024-02-24 at 5 44 09 PM" width="873" 
src="https://private-user-images.githubusercontent.com/9302460/307525897-b37f2d92-d7ff-4a38-a369-81662a6eb59b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNTg5Ny1iMzdmMmQ5Mi1kN2ZmLTRhMzgtYTM2OS04MTY2MmE2ZWI1OWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWY5Y2EwZmJkNzdmYzZjZjY2MDNmYWU3YWM2MmFiMmM4YWI5YWI4ZTZlNDViZDVjNmM5YTg4YzJmMjhlZGZhNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.hhqgtaxwyhRgSS2ylxe4EtAQjEOgMBCk7fT0FSpUkfg";>
   > 
   >     * [ ]  The section color is different
   > 
   >     * [ ]  The font size is different 22px vs 32px
   >       **Design**
   > 
   > 
   > <img alt="Screenshot 2024-02-24 at 5 47 33 PM" width="676" 
src="https://private-user-images.githubusercontent.com/9302460/307526042-10157a88-fa7c-4bdf-8b3f-0f20dc5d910e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNjA0Mi0xMDE1N2E4OC1mYTdjLTRiZGYtOGIzZi0wZjIwZGM1ZDkxMGUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MGQ0ZDAxMWIzOWJiZTJjZTlkZmY5MTJkYjZjZjBhODdmMDdkYjk1YmVlMTVkZDY4ODA1YmMzZmQyODg2MzZjYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.JVfgvU3txSEbvszZfHr070MDf7yO49XEs4i8wRJ_N4c";>
   > 
   > **Implementation** <img alt="Screenshot 2024-02-24 at 5 47 07 PM" 
width="816" 
src="https://private-user-images.githubusercontent.com/9302460/307526022-ed0dc46a-265b-4a8c-b2ee-6b97372de94d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNjAyMi1lZDBkYzQ2YS0yNjViLTRhOGMtYjJlZS02Yjk3MzcyZGU5NGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWZmNTU0M2UzMWFhZDk4NzRkM2IwNzRjZDI2ZDgxZjA3ZDczMDMyMGUzN2JhZDJhMzgyZDZmOGVlMTgxYTg5YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.El2DOe1E08G96GZMXwe3PEFNk0kriVRdXJthWe9WIoU";>
   > 
   >     * [ ]  Font size should be smaller here. 32px vs 40px
   > 
   > 
   > <img alt="Screenshot 2024-02-24 at 5 52 16 PM" width="596" 
src="https://private-user-images.githubusercontent.com/9302460/307526293-396c344a-b11f-4f48-9151-dc576bf84fad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNjI5My0zOTZjMzQ0YS1iMTFmLTRmNDgtOTE1MS1kYzU3NmJmODRmYWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDA0ODRkY2Q0MjIxYmRlNDhmYzNlOTNhYTUwYThhZWZlZWRmMGVjMDRjNjE5YmY1ZmRhN2RjMTk0NWYzMWI2NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.2CnazgH6sFWLthZApc6S8yn5kBQB6cJ57Ld0AsQKc8Q";>
   > 
   >     * [ ]  Vertical padding should be bigger according to the design
   > 
   > 
   > <img alt="Screenshot 2024-02-24 at 5 53 49 PM" width="972" 
src="https://private-user-images.githubusercontent.com/9302460/307526374-fb88c9e1-e2cc-4571-b5d2-295f6f134ac6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNjM3NC1mYjg4YzllMS1lMmNjLTQ1NzEtYjVkMi0yOTVmNmYxMzRhYzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWU4MjVjZWY0ZGZmNDY2MDQxMjY2YTMwM2JjMDE5MzZjYzNhYzZkOTJiYzI4M2VkMzhiMTA0NThlYzBkMzk2NiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.vVpz_X4wlJ3Y7zUe6kA9ZdLcC6-KtF656wzLcDFFCiI";>
   > 
   >     * [ ]  Font size should be smaller here according the design
   > 
   > 
   > <img alt="Screenshot 2024-02-24 at 5 54 54 PM" width="619" 
src="https://private-user-images.githubusercontent.com/9302460/307526446-f0a8d5cd-0a14-4bb3-8504-7cf37fc436bb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNjQ0Ni1mMGE4ZDVjZC0wYTE0LTRiYjMtODUwNC03Y2YzN2ZjNDM2YmIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjE5MWIwMDVmMDM0MjE0MTBiMWVjOWNhYWUzNjczYWY1YTZiODA3ZGE3NDUyZDU2NDI1NGYyMTFkNmQyOGYyNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.RS11x8FhYchV8SOggCcUQR6j4r8jC8QFZdG_fo-TUeI";>
   > 
   >     * [ ]  Font size should be smaller here..18px vs 24px
   > 
   > 
   > <img alt="Screenshot 2024-02-24 at 5 57 02 PM" width="981" 
src="https://private-user-images.githubusercontent.com/9302460/307526582-240a09b5-989d-47f8-8189-790f15e697bd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNjU4Mi0yNDBhMDliNS05ODlkLTQ3ZjgtODE4OS03OTBmMTVlNjk3YmQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDhkYjVlY2VmM2IwZTdkOGMwODY0YmJkODI4NmU5MmFlMGM4YThmZmQxNzBjOTYxYmMzYTBiOTk5ZDQ3ZDUxNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.UTjhYl2tWmuA4uNBgekTIiJcI9iR9ynQ58-mhmLfMTY";>
   > 
   >     * [ ]  Vertical padding should be smaller here.
   > 
   >     * [ ]  Font size should be bigger.
   > 
   > 
   > <img alt="Screenshot 2024-02-24 at 5 57 42 PM" width="873" 
src="https://private-user-images.githubusercontent.com/9302460/307526617-43487919-4695-40b9-8e02-638f21b7e552.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNjYxNy00MzQ4NzkxOS00Njk1LTQwYjktOGUwMi02MzhmMjFiN2U1NTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmUwMjUzNWQ1ZTdjYWFjZjE0ODNlYjBkN2VjZDljYTA5MTdhNmRiYWZiNGVhZjk0Yzg5ZWFhYjdlOTVhZThiYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.ELGpGi7LyUAJQbz5AZHB4b_sb3h16QFWZd6U5-KJiM0";>
   > 
   >     * [ ]  Vertical padding should be smaller
   > 
   >     * [ ]  Items should be vertically centered
   > 
   >     * [ ]  Font size should be different
   > 
   > 
   > <img alt="Screenshot 2024-02-24 at 5 59 26 PM" width="1438" 
src="https://private-user-images.githubusercontent.com/9302460/307526718-bb210f32-a0d6-439d-8728-939434a29565.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MTQ3NzMsIm5iZiI6MTcwOTgxNDQ3MywicGF0aCI6Ii85MzAyNDYwLzMwNzUyNjcxOC1iYjIxMGYzMi1hMGQ2LTQzOWQtODcyOC05Mzk0MzRhMjk1NjUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMDdUMTIyNzUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDFmMThkMDY0YTAyYWY2ZDg2MGI5NDhhZGIxNTU5Y2EwMTY1MmFjYTJhYTRjYzU1YmNhYjkxYWNlMjdmZDU1ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.3IPTb7zd6elAeNjEUfNPbjtGCgHZb625YqebbJhf6o0";>
   > 
   > @Trakina you can double-click any Figma element to get the desired font 
size and compare it with font size at the computed styles tab in your browser 
devtools.
   > 
   > Could you please ensure that font sizes and paddings are correct across 
the other pages and make the corresponding fixes?
   
   The order was discussed between us on slack, if I recall correctly. Hence 
the difference. Figma was never updated, but the order was implemented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org