visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530277540
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -53,6 +63,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername?.[0] || member.apacheId;
Review Comment:
> this might make a wrong choice for some users. It might be better to not
assume that github username matches the apache id.
Agree. In this case, we should render a regular div instead of a link that
refers to the GitHub profile or `#`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
