visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530295588
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -64,7 +64,10 @@ export default function CommunityPage(): JSX.Element {
});
function MemberCard({ member, index }) {
- const githubUsername = member.githubUsername?.[0] || member.apacheId;
+ // require the member to have "GitHub username(s) (user-provided)" field
information in Whimsy
+ // the user can go to Whimsy url
https://whimsy.apache.org/roster/committer/__self__ to update the information
Review Comment:
I just tried, but it looks broken:
<img width="529" alt="Screenshot 2024-03-19 at 4 44 15 PM"
src="https://github.com/apache/pulsar-site/assets/9302460/dce8d71b-f028-4c57-9128-58c4aa87f6b2";>
At the same time after I clicked the "Link GitHub username(s) to ASF id":
<img width="687" alt="Screenshot 2024-03-19 at 4 45 26 PM"
src="https://github.com/apache/pulsar-site/assets/9302460/c051b4c2-62dd-4a3d-b7d0-e62976f2fa82";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
