thetumbled commented on PR #22452: URL: https://github.com/apache/pulsar/pull/22452#issuecomment-2046504894
> I just don't understand, it seems ReplicatorSubscriptionController only snapshots `ledger.lastPosition`, why do we update `lastDataMessagePublishedTimestamp` after `maxReadPosition` moved? Fisrt of all, this pr is to fix the bug that `lastDataMessagePublishedTimestamp` can't move anyway, which result into the bug `replicated subscriptions not work for transactional messages`. So we need to move it for transactional messages. Secondly, it is meaningless that we snapshot a unreachable position. `ledger.lastPosition` can be greater than the max read position. So we need to move it for transactional messages when the max read position really changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
