lhotari commented on code in PR #22452:
URL: https://github.com/apache/pulsar/pull/22452#discussion_r1559163062
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -674,6 +700,10 @@ private void
closeReader(SystemTopicClient.Reader<TransactionBufferSnapshot> rea
}
}
+ public interface MaxReadPositionCallBack {
+ void moveForward(PositionImpl oldPosition, PositionImpl newPosition);
Review Comment:
`moveForward` is in imperative format and it sounds like a command. It would
be better to rename it so that it's clear that this is an event.
`maxReadPositionMovedForward` would be one possibility.
Please also add Javadoc that clarifies the purpose and contract of this
interface and the event information that the method call provides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
