BewareMyPower commented on code in PR #22487:
URL: https://github.com/apache/pulsar/pull/22487#discussion_r1572038446
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadManager.java:
##########
@@ -63,7 +65,7 @@ public interface LoadManager {
Optional<ResourceUnit> getLeastLoaded(ServiceUnitId su) throws Exception;
default CompletableFuture<Optional<LookupResult>> findBrokerServiceUrl(
- Optional<ServiceUnitId> topic, ServiceUnitId bundle) {
+ Optional<ServiceUnitId> topic, NamespaceBundle bundle,
LookupOptions options) {
throw new UnsupportedOperationException();
}
Review Comment:
It's better to keep the API compatibility since it's an interface that can
be configured. You can keep the 2nd parameter as `ServiceUnitId` and add a new
default method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
