BewareMyPower commented on code in PR #22487:
URL: https://github.com/apache/pulsar/pull/22487#discussion_r1574488674
##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/loadbalance/ExtensibleLoadManagerTest.java:
##########
@@ -405,7 +405,7 @@ public void testIsolationPolicy() throws Exception {
admin.lookups().lookupTopicAsync(topic).get(5,
TimeUnit.SECONDS);
Review Comment:
Should you add `fail()` here?
##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/loadbalance/ExtensibleLoadManagerTest.java:
##########
@@ -405,7 +405,7 @@ public void testIsolationPolicy() throws Exception {
admin.lookups().lookupTopicAsync(topic).get(5,
TimeUnit.SECONDS);
} catch (Exception ex) {
log.error("Failed to lookup topic: ", ex);
Review Comment:
It seems that the lookup error could be `TimeoutException` before retrying
until the error becomes "Service Unavailable". Is it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
