lhotari commented on code in PR #22607:
URL: https://github.com/apache/pulsar/pull/22607#discussion_r1582555578
##########
pom.xml:
##########
@@ -765,18 +765,21 @@ flexible messaging model and an intuitive client
API.</description>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
+ <scope>provided</scope>
Review Comment:
I think that `slf4j-api` should be kept in default (compile) scope. Users of
the library can use dependency management to enforce a specific version of
slf4j-api. Dependency resolution picks the "closest" dependency by default when
there are version conflicts. It's better to rely on this for slf4j-api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
