BewareMyPower commented on code in PR #22607:
URL: https://github.com/apache/pulsar/pull/22607#discussion_r1582592478


##########
pom.xml:
##########
@@ -765,18 +765,21 @@ flexible messaging model and an intuitive client 
API.</description>
         <groupId>org.slf4j</groupId>
         <artifactId>slf4j-api</artifactId>
         <version>${slf4j.version}</version>
+        <scope>provided</scope>

Review Comment:
   The default `compile` scope breaks many downstream applications, as I've 
said in https://lists.apache.org/thread/4omvl62k4jhntj3rsywp14zzgh1l3l9q
   
   With the `compile` scope, we should revert 
https://github.com/apache/pulsar/pull/22391.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to