nodece commented on code in PR #22607:
URL: https://github.com/apache/pulsar/pull/22607#discussion_r1583308460
##########
pom.xml:
##########
@@ -765,18 +765,21 @@ flexible messaging model and an intuitive client
API.</description>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
+ <scope>provided</scope>
Review Comment:
Another point is that #22391 will be released at 3.3.0. When users upgrade
to the pulsar version, they must pay attention to the version of slf4j. We need
to mention this in the release note.
> In the future, since there are both SLF4J 1.7.x and 2.x, any project would
have to use dependency management to select the desired version for that
project.
In the mailing list, I said:
Unifying SLF4J is quite difficult, many libraries include the slf4j 1.x or
2.x, and when the slf4j version is inconsistent, we still need to use
`<exclude>`.
This PR ensures that downstream users can use either slf4j 1. x or 2. x,
once the pulsar uses the slf4j 2.x
api(https://www.slf4j.org/manual.html#fluent), this will force users to upgrade
to slf4j 2.x.
For me, using scope `compile` is correct.
> All Java based projects will have to deal with this eventually so this
challenge isn't specific to Pulsar.
+1, just like what I did in #22391, unify the slf4j version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
