dao-jun commented on code in PR #22652:
URL: https://github.com/apache/pulsar/pull/22652#discussion_r1590509904


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java:
##########
@@ -395,6 +396,8 @@ public void initializeComplete() {
 
                     // May need to update the cursor position
                     newledger.maybeUpdateCursorBeforeTrimmingConsumedLedger();
+                    // May need to trigger offloading
+                    newledger.maybeOffloadInBackground(NULL_OFFLOAD_PROMISE);

Review Comment:
   Just a suggestion, maybe trigger offloading in 
BrokerService#createPersistentTopic is better?
   Trigger offloading after PersistentTopic load finished:
   
![image](https://github.com/apache/pulsar/assets/21362791/4c9119f0-8bf3-45f5-9d02-fdf658adbbdc)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to