hangc0276 commented on code in PR #22652:
URL: https://github.com/apache/pulsar/pull/22652#discussion_r1590512152
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java:
##########
@@ -395,6 +396,8 @@ public void initializeComplete() {
// May need to update the cursor position
newledger.maybeUpdateCursorBeforeTrimmingConsumedLedger();
+ // May need to trigger offloading
+ newledger.maybeOffloadInBackground(NULL_OFFLOAD_PROMISE);
Review Comment:
Offload is a managedledger level feature and does not need to be exposed as
the topic-level feature. From the feature scope perspective, we'd better keep
it at the managedledger level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
