RobertIndie commented on code in PR #22698:
URL: https://github.com/apache/pulsar/pull/22698#discussion_r1597790380
##########
pulsar-client/src/main/java/org/apache/pulsar/client/util/MessageIdUtils.java:
##########
@@ -19,11 +19,12 @@
package org.apache.pulsar.client.util;
import org.apache.pulsar.client.api.MessageId;
+import org.apache.pulsar.client.api.MessageIdAdv;
import org.apache.pulsar.client.impl.MessageIdImpl;
public class MessageIdUtils {
Review Comment:
This is also used in third-party connectors, not just limited to the kafka
sink connector.
Removing the `offset` from the pulsar-client looks good to me. I think we
can mark it with `Deprecate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
