BewareMyPower commented on code in PR #22698:
URL: https://github.com/apache/pulsar/pull/22698#discussion_r1599348776
##########
pulsar-client/src/main/java/org/apache/pulsar/client/util/MessageIdUtils.java:
##########
@@ -19,11 +19,12 @@
package org.apache.pulsar.client.util;
import org.apache.pulsar.client.api.MessageId;
+import org.apache.pulsar.client.api.MessageIdAdv;
import org.apache.pulsar.client.impl.MessageIdImpl;
public class MessageIdUtils {
Review Comment:
Yes. Before removing it, we can mark it with `@Deprecated`.
In 3rd party applications, it's easy to customize its own implementation via
`MessageIdAdv`. You can see the example from an early implementation of KoP:
https://github.com/streamnative/kop/blob/branch-2.7.4.5/kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/utils/MessageIdUtils.java,
which is also an example to show the way to compute the offset is not standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
