rayluoluo commented on code in PR #23192:
URL: https://github.com/apache/pulsar/pull/23192#discussion_r1722990874
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LinuxInfoUtils.java:
##########
@@ -251,7 +251,9 @@ public static double getTotalNicLimit(List<String> nics,
BitRateUnit bitRateUnit
try {
return
readDoubleFromFile(getReplacedNICPath(NIC_SPEED_TEMPLATE, nicPath));
} catch (IOException e) {
- log.error("[LinuxInfo] Failed to get total nic limit.", e);
Review Comment:
The configuration item `loadBalancerOverrideBrokerNicSpeedGbps` is used to
override the auto-detection of the network interface max speed.
In fact, the system (for example, in the case of multiple NICs) can read the
maximum speed of the NICs that are active.
On the other hand, the network interface max speed of each broker node may
be different. If a fixed value is manually configured to overwrite the
automatic detection mechanism, the problem handling becomes complex.
I think using the configuration item is only a workaround, not the best way
to solve the problem.
Thank you for your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
