lhotari commented on code in PR #23192:
URL: https://github.com/apache/pulsar/pull/23192#discussion_r1731524195
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LinuxInfoUtils.java:
##########
@@ -60,6 +62,7 @@ public class LinuxInfoUtils {
private static Method getCpuQuotaMethod;
private static Method getCpuPeriodMethod;
private static Method getCpuUsageMethod;
+ private static Set<String> exposeNicLimitFaultCompleted = new HashSet<>();
Review Comment:
This should be wrapped with `Collections.synchronizedSet` to make the usage
thread safe.
```
private static Set<String> exposeNicLimitFaultCompleted =
Collections.synchronizedSet(new HashSet<>());
```
perhaps renaming the field name from `exposeNicLimitFaultCompleted` could
improve the readability of the code. Perhaps it could be
`failedNicPathsInReadingNicLimits`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
