poorbarcode commented on code in PR #23237:
URL: https://github.com/apache/pulsar/pull/23237#discussion_r1738318410
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1810,6 +1810,28 @@ public void closeFailed(ManagedLedgerException
exception, Object ctx) {
return closeFuture;
}
+ private boolean isClosed() {
Review Comment:
Good point, but I am thinking about the following things
- The marker that is used to confirm whether a topic is closed or not is
needed, I want to add a `State` for `PersistentTopic`, which will combine
`isFenced`, `isClosingOrDeleted`...
- And replicator relates to `PersistentTopic`, not `ManagedLedger`, so using
the state of Persistent Topic is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
