poorbarcode commented on code in PR #23237:
URL: https://github.com/apache/pulsar/pull/23237#discussion_r1739883971


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1810,6 +1810,28 @@ public void closeFailed(ManagedLedgerException 
exception, Object ctx) {
         return closeFuture;
     }
 
+    private boolean isClosed() {

Review Comment:
   > Do we need to close the topic if the managed ledger closed?
   
   Yes, the managed ledger always be closed following the topic's closing. And 
regarding this case, the topic and managed ledger all be closed, but the retry 
task still runs 😂 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to