BewareMyPower commented on code in PR #23349:
URL: https://github.com/apache/pulsar/pull/23349#discussion_r1776540279
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -1381,8 +1400,10 @@ private void overrideOwnership(String serviceUnit,
ServiceUnitStateData orphanDa
private void waitForCleanups(String broker, boolean excludeSystemTopics,
int maxWaitTimeInMillis) {
long started = System.currentTimeMillis();
Review Comment:
> if the broker to cleanup is the last broker.
I found sometimes the cleanup did not fail for the last broker but for the
2nd broker in `testCloseAfterLoadingBundles`.
```
2024-09-26T15:35:56,001 - INFO - [main:BrokerService] - Disable broker in
load manager completed in 0.081 seconds
2024-09-26T15:36:31,287 - INFO - [main:BrokerService] - Disable broker in
load manager completed in 35.099 seconds
2024-09-26T15:36:31,644 - INFO - [main:BrokerService] - Disable broker in
load manager completed in 0.214 seconds
2024-09-26T15:36:31,783 - INFO - [main:ExtensibleLoadManagerCloseTest] -
Brokers close time: [275, 35242, 354]
```
Let me look it deeper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
