heesung-sn commented on code in PR #23349:
URL: https://github.com/apache/pulsar/pull/23349#discussion_r1775953506
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -307,7 +309,7 @@ public synchronized void start() throws
PulsarServerException {
pulsar.getConfiguration().getDefaultNumberOfNamespaceBundles());
tableview = createServiceUnitStateTableView();
- tableview.start(pulsar, this::handleEvent, this::handleExisting);
+ tableview.start(pulsar, this::handleEvent, this::handleExisting,
this::handleSkippedEvent);
Review Comment:
I am actually not sure if this skip logic is required as this can return
deferred lookups too soon(or introduce unnecessary state changes on skipped
messages).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
