lhotari commented on code in PR #23378:
URL: https://github.com/apache/pulsar/pull/23378#discussion_r1799213499
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java:
##########
@@ -163,29 +165,30 @@ public SchemaInfoProvider load(String topicName) {
private TransactionCoordinatorClientImpl tcClient;
public PulsarClientImpl(ClientConfigurationData conf) throws
PulsarClientException {
- this(conf, null, null, null, null, null, null);
+ this(conf, null, null, null, null, null, null, null);
}
public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup
eventLoopGroup) throws PulsarClientException {
- this(conf, eventLoopGroup, null, null, null, null, null);
+ this(conf, eventLoopGroup, null, null, null, null, null, null);
}
public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup
eventLoopGroup, ConnectionPool cnxPool)
throws PulsarClientException {
- this(conf, eventLoopGroup, cnxPool, null, null, null, null);
+ this(conf, eventLoopGroup, cnxPool, null, null, null, null, null);
}
public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup
eventLoopGroup, ConnectionPool cnxPool,
Timer timer)
throws PulsarClientException {
- this(conf, eventLoopGroup, cnxPool, timer, null, null, null);
+ this(conf, eventLoopGroup, cnxPool, timer, null, null, null, null);
}
@Builder(builderClassName = "PulsarClientImplBuilder")
private PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup
eventLoopGroup, ConnectionPool connectionPool,
Timer timer, ExecutorProvider
externalExecutorProvider,
ExecutorProvider internalExecutorProvider,
- ScheduledExecutorProvider
scheduledExecutorProvider) throws PulsarClientException {
+ ScheduledExecutorProvider
scheduledExecutorProvider,
+ ExecutorProvider lookupExecutorProvider) throws
PulsarClientException {
Review Comment:
please add the original constructor so that delegated to this modified
constructor so that we don't break binary compatibility of the previous class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
