lhotari commented on code in PR #23378:
URL: https://github.com/apache/pulsar/pull/23378#discussion_r1799427644
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java:
##########
@@ -218,11 +231,14 @@ private PulsarClientImpl(ClientConfigurationData conf,
EventLoopGroup eventLoopG
new ExecutorProvider(conf.getNumListenerThreads(),
"pulsar-external-listener");
this.internalExecutorProvider = internalExecutorProvider != null ?
internalExecutorProvider :
new ExecutorProvider(conf.getNumIoThreads(),
"pulsar-client-internal");
+ this.lookupExecutorProvider = lookupExecutorProvider != null ?
lookupExecutorProvider :
+ new ExecutorProvider(conf.getNumIoThreads(),
"pulsar-client-lookup");
Review Comment:
I don't think that numIoThread should be used for this purpose. It's already
used for the `scheduledExecutorProvider`, but that's not a great default at
all. This could cause regressions due to memory increase.
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java:
##########
@@ -218,11 +231,14 @@ private PulsarClientImpl(ClientConfigurationData conf,
EventLoopGroup eventLoopG
new ExecutorProvider(conf.getNumListenerThreads(),
"pulsar-external-listener");
this.internalExecutorProvider = internalExecutorProvider != null ?
internalExecutorProvider :
new ExecutorProvider(conf.getNumIoThreads(),
"pulsar-client-internal");
+ this.lookupExecutorProvider = lookupExecutorProvider != null ?
lookupExecutorProvider :
+ new ExecutorProvider(conf.getNumIoThreads(),
"pulsar-client-lookup");
Review Comment:
I don't think that numIoThread should be used for this purpose. It's already
used for the `scheduledExecutorProvider`, but that's not a great default at
all. This could cause regressions due to memory consumption increase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
