nodece commented on code in PR #23515:
URL: https://github.com/apache/pulsar/pull/23515#discussion_r1817894831
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/OwnershipCache.java:
##########
@@ -170,7 +170,17 @@ public CompletableFuture<Optional<NamespaceEphemeralData>>
getOwnerAsync(Namespa
// If we're not the owner, we need to check if anybody else is
String path = ServiceUnitUtils.path(suName);
- return lockManager.readLock(path);
+ return lockManager.readLock(path).thenCompose(owner -> {
+ //If the current broker is the owner, we must try to acquire
ownership to avoid cache loss.
Review Comment:
> Is it possible to reproduce this in a test?
“org.apache.pulsar.client.api.BrokerServiceLookupTest#testLookupConnectionNotCloseIfGetUnloadingExOrMetadataExalways”
fail locally, but this test works fine in the apache/pulsar ci(because we can
merge the PR to the master), it is confusing to me.
Could you try to run this test?
The root cause is the topic’s ownership not found in the ownedBundlesCache,
and then the broker sends an error to the client, so you see the client is
reconnecting. When the ownership is never found, the client keeps trying
reconnect. Please check the WARN log from the PR description for details. I
hope this log can help you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
