poorbarcode commented on code in PR #23515:
URL: https://github.com/apache/pulsar/pull/23515#discussion_r1818332494


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/OwnershipCache.java:
##########
@@ -170,7 +170,17 @@ public CompletableFuture<Optional<NamespaceEphemeralData>> 
getOwnerAsync(Namespa
 
         // If we're not the owner, we need to check if anybody else is
         String path = ServiceUnitUtils.path(suName);
-        return lockManager.readLock(path);
+        return lockManager.readLock(path).thenCompose(owner -> {
+            //If the current broker is the owner, we must try to acquire 
ownership to avoid cache loss.

Review Comment:
   @nodece 
   
   I can not find a test named 
`testLookupConnectionNotCloseIfGetUnloadingExOrMetadataExalways` in the test 
class named `org.apache.pulsar.client.api.BrokerServiceLookupTest`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to