nodece commented on code in PR #1301:
URL: https://github.com/apache/pulsar-client-go/pull/1301#discussion_r1825573287
##########
pulsar/consumer_partition.go:
##########
@@ -683,6 +688,83 @@ func (pc *partitionConsumer) AckID(msgID MessageID) error {
return pc.ackID(msgID, false)
}
+func (pc *partitionConsumer) AckIDList(msgIDs []MessageID) map[MessageID]error
{
+ errorMap := make(map[MessageID]error)
+ if !pc.options.ackWithResponse {
+ for _, msgID := range msgIDs {
+ if err := pc.ackID(msgID, false); err != nil {
+ errorMap[msgID] = err
+ }
+ }
+ return errorMap
+ }
+
+ chunkedMsgIDs := make([]*chunkMessageID, 0) // we need to remove them
after acknowledging
+ pendingAcks := make(map[position]*bitset.BitSet)
+
+ // They might be complete after the whole for loop
+ incompleteTrackingIDs := make([]*trackingMessageID, 0)
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
