BewareMyPower commented on PR #1301: URL: https://github.com/apache/pulsar-client-go/pull/1301#issuecomment-2451746920
@RobertIndie @nodece @crossoverJie @shibd Thanks for your reviews. The `AckIDList` API is updated now. For the simple consumer case that only 1 topic is subscribed, since only 1 ACK request will be sent, these message IDs either all fail or all succeed. The only exceptional case is that invalid message IDs are passed. However, in this case, there is no way to handle these message IDs because acknowledging them will always fail. Hence I just return a trivial `error` here. However, if the consumer subscribes multiple topics, there might be multiple `partitionConsumer` objects here, each of them has a separated events channel (`eventsCh`) so multiple ACK requests could be sent. Therefore, an `AckError` will be returned, which contains a map that maps the failed message ID to its error. See the API documents and the tests for details. PTAL again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
