lhotari commented on PR #23600: URL: https://github.com/apache/pulsar/pull/23600#issuecomment-2475973299
This is a very poor solution in the current implementation: https://github.com/apache/pulsar/blob/22cfa5428ef8a4fc6cfc0225182724012f0972c2/pulsar-client/src/main/java/org/apache/pulsar/client/impl/NegativeAcksTracker.java#L80-L88 There should be a separate datastructure (a list or queue) which contains the entries in timestamp order. The benefit of that is that iterating could stop after the timestamp condition no longer holds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
