thetumbled commented on PR #23600: URL: https://github.com/apache/pulsar/pull/23600#issuecomment-2478175728
> > You are right. We need to improve the code execution efficiency too. some kind of structures sorted by timestamp. > > Fastutil contains multiple PriorityQueue implementations: https://fastutil.di.unimi.it/docs/it/unimi/dsi/fastutil/PriorityQueue.html. For example, this would work: https://fastutil.di.unimi.it/docs/it/unimi/dsi/fastutil/objects/ObjectArrayPriorityQueue.html or this one: https://fastutil.di.unimi.it/docs/it/unimi/dsi/fastutil/objects/ObjectHeapPriorityQueue.html I propose a pip to fix several issues with nack tracker, with a new data structure : ``` Long2ObjectSortedMap<Long2ObjectMap<Roaring64Bitmap>> nackedMessages = new Long2ObjectAVLTreeMap<>(); ``` This PR become the implementation PR for PIP-393: https://github.com/apache/pulsar/pull/23601. I will implement PIP-393 soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
