thetumbled commented on code in PR #23791:
URL: https://github.com/apache/pulsar/pull/23791#discussion_r1899342659
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -436,20 +436,22 @@ private void onSendComplete(Throwable e, SendCallback
sendCallback, MessageImpl<
if (payload == null) {
log.error("[{}] [{}] Payload is null when calling
onSendComplete, which is not expected.",
topic, producerName);
- } else {
- ReferenceCountUtil.safeRelease(payload);
}
- if (e != null) {
- latencyHistogram.recordFailure(latencyNanos);
- stats.incrementSendFailed();
- onSendAcknowledgement(msg, null, e);
- sendCallback.getFuture().completeExceptionally(e);
- } else {
- latencyHistogram.recordSuccess(latencyNanos);
- publishedBytesCounter.add(msgSize);
- stats.incrementNumAcksReceived(latencyNanos);
- onSendAcknowledgement(msg, msg.getMessageId(), null);
- sendCallback.getFuture().complete(msg.getMessageId());
+ try {
+ if (e != null) {
+ latencyHistogram.recordFailure(latencyNanos);
+ stats.incrementSendFailed();
+ onSendAcknowledgement(msg, null, e);
+ sendCallback.getFuture().completeExceptionally(e);
+ } else {
+ latencyHistogram.recordSuccess(latencyNanos);
+ publishedBytesCounter.add(msgSize);
+ stats.incrementNumAcksReceived(latencyNanos);
+ onSendAcknowledgement(msg, msg.getMessageId(), null);
+ sendCallback.getFuture().complete(msg.getMessageId());
+ }
+ } finally {
+ ReferenceCountUtil.safeRelease(payload);
Review Comment:
This patch change the original logic.
```
if (payload == null) {
log.error("[{}] [{}] Payload is null when calling
onSendComplete, which is not expected.",
topic, producerName);
} else {
ReferenceCountUtil.safeRelease(payload);
}
```
Before this patch, only payload is not null we will release it, while after
this patch, the null check is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
