Shawyeok commented on code in PR #23791:
URL: https://github.com/apache/pulsar/pull/23791#discussion_r1899344892
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -436,20 +436,22 @@ private void onSendComplete(Throwable e, SendCallback
sendCallback, MessageImpl<
if (payload == null) {
log.error("[{}] [{}] Payload is null when calling
onSendComplete, which is not expected.",
topic, producerName);
- } else {
- ReferenceCountUtil.safeRelease(payload);
}
- if (e != null) {
- latencyHistogram.recordFailure(latencyNanos);
- stats.incrementSendFailed();
- onSendAcknowledgement(msg, null, e);
- sendCallback.getFuture().completeExceptionally(e);
- } else {
- latencyHistogram.recordSuccess(latencyNanos);
- publishedBytesCounter.add(msgSize);
- stats.incrementNumAcksReceived(latencyNanos);
- onSendAcknowledgement(msg, msg.getMessageId(), null);
- sendCallback.getFuture().complete(msg.getMessageId());
+ try {
+ if (e != null) {
+ latencyHistogram.recordFailure(latencyNanos);
+ stats.incrementSendFailed();
+ onSendAcknowledgement(msg, null, e);
+ sendCallback.getFuture().completeExceptionally(e);
+ } else {
+ latencyHistogram.recordSuccess(latencyNanos);
+ publishedBytesCounter.add(msgSize);
+ stats.incrementNumAcksReceived(latencyNanos);
+ onSendAcknowledgement(msg, msg.getMessageId(), null);
+ sendCallback.getFuture().complete(msg.getMessageId());
+ }
+ } finally {
+ ReferenceCountUtil.safeRelease(payload);
Review Comment:
Oh, `ReferenceCountUtil.safeRelease` is null-safe as its name suggests. It
does nothing if invoked with a `null` value, and this behavior is explicitly
documented in its Javadoc.
https://github.com/netty/netty/blob/c7de17a7f385a8a2156ddc9e74c7a85a6651a034/common/src/main/java/io/netty/util/ReferenceCountUtil.java#L114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
