lhotari commented on code in PR #23796:
URL: https://github.com/apache/pulsar/pull/23796#discussion_r1900215274
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java:
##########
@@ -595,6 +595,7 @@ private CompletableFuture<Long>
individualAckNormal(CommandAck ack, Map<String,
ackedCount = getAckedCountForMsgIdNoAckSets(batchSize,
position, ackOwnerConsumer);
if (checkCanRemovePendingAcksAndHandle(ackOwnerConsumer,
position, msgId)) {
addAndGetUnAckedMsgs(ackOwnerConsumer, -(int) ackedCount);
+ updateBlockedConsumerOnUnackedMsgs(ackOwnerConsumer);
Review Comment:
acks get modified also on line 592 in a similar way as on line 597. Just
wondering if the logic in `updateBlockedConsumerOnUnackedMsgs` should be moved
directly into `addAndGetUnAckedMsgs` method so that all changes would get
covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
