summeriiii commented on code in PR #23796:
URL: https://github.com/apache/pulsar/pull/23796#discussion_r1901452594
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java:
##########
@@ -595,6 +595,7 @@ private CompletableFuture<Long>
individualAckNormal(CommandAck ack, Map<String,
ackedCount = getAckedCountForMsgIdNoAckSets(batchSize,
position, ackOwnerConsumer);
if (checkCanRemovePendingAcksAndHandle(ackOwnerConsumer,
position, msgId)) {
addAndGetUnAckedMsgs(ackOwnerConsumer, -(int) ackedCount);
+ updateBlockedConsumerOnUnackedMsgs(ackOwnerConsumer);
Review Comment:
On line 592, the msgId.getAckSetsCount() > 0 (ack at batch index level) ,
for this case, we may call removePendingAcks later which can
updateBlockedConsumerOnUnackedMsgs
https://github.com/apache/pulsar/blob/d377bc9d7321a66201a301b6887fb1fea3ef8820/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L618-L624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
