lhotari commented on code in PR #23886:
URL: https://github.com/apache/pulsar/pull/23886#discussion_r1928832844
##########
pulsar-client-shaded/pom.xml:
##########
@@ -336,10 +336,6 @@
<pattern>org.apache.commons</pattern>
<shadedPattern>org.apache.pulsar.shade.org.apache.commons</shadedPattern>
</relocation>
- <relocation>
- <pattern>org.apache.pulsar.policies</pattern>
-
<shadedPattern>org.apache.pulsar.shade.org.apache.pulsar.policies</shadedPattern>
- </relocation>
Review Comment:
Add the excludes rule described earlier.
##########
pulsar-client-all/pom.xml:
##########
@@ -424,10 +424,6 @@
<pattern>org.apache.commons</pattern>
<shadedPattern>org.apache.pulsar.shade.org.apache.commons</shadedPattern>
</relocation>
- <relocation>
- <pattern>org.apache.pulsar.policies</pattern>
-
<shadedPattern>org.apache.pulsar.shade.org.apache.pulsar.policies</shadedPattern>
- </relocation>
Review Comment:
Add the excludes rule described earlier.
##########
pulsar-client-admin-shaded/pom.xml:
##########
@@ -364,10 +364,6 @@
<pattern>org.apache.pulsar.checksum</pattern>
<shadedPattern>org.apache.pulsar.shade.org.apache.pulsar.checksum</shadedPattern>
</relocation>
- <relocation>
- <pattern>org.apache.pulsar.policies</pattern>
-
<shadedPattern>org.apache.pulsar.shade.org.apache.pulsar.policies</shadedPattern>
- </relocation>
Review Comment:
Instead of removing the relocation rule, add a exclude rule so that the
classes and interfaces in
https://github.com/apache/pulsar/tree/master/pulsar-client-admin-api/src/main/java/org/apache/pulsar/policies/data/loadbalancer
aren't shaded:
```xml
<excludes>
<exclude>org\.apache\.pulsar\.policies\.data\.loadbalancer\.(LoadManagerReport|NamespaceBundleStats|ResourceUsage|ServiceLookupData)($.*)?</exclude>
</excludes>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
