nodece commented on PR #23886: URL: https://github.com/apache/pulsar/pull/23886#issuecomment-2612919803
> > @lhotari What's your opinion? > > @nodece I've suggested a fix in [#23886 (review)](https://github.com/apache/pulsar/pull/23886#pullrequestreview-2572592840) . Have you checked that? This is an error fix, I still got the same error. `org.apache.pulsar.shade.org.apache.pulsar.policies.data.loadbalancer.LoadManagerReport` does not exist. > Public interfaces shouldn't be shaded. Implementation classes should be shaded. I understand that this is the correct way. Your changes are correct. > Shading will change that to be the shaded class name and as a result of this, the deserialization will fail since there's a difference between client side and broker side for the value of the `loadReportType` field. ``` public static final String loadReportType = LoadReport.class.getSimpleName(); ``` The `loadReportType` value is a simple name, so we don't need to consider the full name, and this means `LoadReportDeserializer` should not modified. ``` <excludes> <!-- exclude references to unshaded classes and interfaces in https://github.com/apache/pulsar/tree/master/pulsar-client-admin-api/src/main/java/org/apache/pulsar/policies/data/loadbalancer --> <exclude>org\.apache\.pulsar\.policies\.data\.loadbalancer\.(LoadManagerReport|NamespaceBundleStats|ResourceUsage|ServiceLookupData)($.*)?</exclude> </excludes> ``` It doesn't work, so I use the following code instead of that: ``` <excludes> <exclude>org.apache.pulsar.policies.data.loadbalancer.LoadManagerReport</exclude> <exclude>org.apache.pulsar.policies.data.loadbalancer.NamespaceBundleStats</exclude> <exclude>org.apache.pulsar.policies.data.loadbalancer.ResourceUsage</exclude> <exclude>org.apache.pulsar.policies.data.loadbalancer.ServiceLookupData</exclude> </excludes> ``` @lhotari Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
