lhotari commented on code in PR #23902:
URL: https://github.com/apache/pulsar/pull/23902#discussion_r1934752768


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/ResourceLockImpl.java:
##########
@@ -188,6 +188,17 @@ private CompletableFuture<Void> 
acquireWithNoRevalidation(T newValue) {
         CompletableFuture<Void> result = new CompletableFuture<>();
         store.put(path, payload, Optional.of(version), 
EnumSet.of(CreateOption.Ephemeral))
                 .thenAccept(stat -> {
+                    if (!stat.isEphemeral()) {

Review Comment:
   @heesung-sn I pushed some changes to this PR for 
MockZooKeeperSession/MockZooKeeper to support ephemeral owner. The value for 
persistent nodes is now 0. Support was missing completely for multi-ops. In the 
mock zookeeper solution, the session id gets passed in a thread local since 
there's not another way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to