lhotari commented on code in PR #23902:
URL: https://github.com/apache/pulsar/pull/23902#discussion_r1951746050
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/ResourceLockImpl.java:
##########
@@ -188,6 +188,17 @@ private CompletableFuture<Void>
acquireWithNoRevalidation(T newValue) {
CompletableFuture<Void> result = new CompletableFuture<>();
store.put(path, payload, Optional.of(version),
EnumSet.of(CreateOption.Ephemeral))
.thenAccept(stat -> {
+ if (!stat.isEphemeral()) {
Review Comment:
@heesung-sn I added `.withTestZookeeper` support to `PulsarTestContext` and
an easy way to use this in tests, that's in commit 17ec37a. I modified
BrokerServiceLookupTest to use it so that it runs for both. That's useful for
comparing the results and catching problems when using real ZooKeeper. It seems
that there's a bigger mess to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
