rdhabalia commented on code in PR #60:
URL: https://github.com/apache/pulsar-adapters/pull/60#discussion_r1960447003
##########
pulsar-storm/src/main/java/org/apache/pulsar/storm/PulsarSpout.java:
##########
@@ -325,7 +345,13 @@ public void declareOutputFields(OutputFieldsDeclarer
declarer) {
private boolean mapToValueAndEmit(Message<byte[]> msg) {
if (msg != null) {
- Values values =
pulsarSpoutConf.getMessageToValuesMapper().toValues(msg);
+ Values values;
+ try{
+ values =
pulsarSpoutConf.getMessageToValuesMapper().toValues(msg);
+ } catch (Exception e){
Review Comment:
this change doesn't seem related to this PR? did we see any issue with the
mapper failure? can we create a separate PR with the details if you have come
across with such issue?
##########
pulsar-storm/src/main/java/org/apache/pulsar/storm/PulsarSpout.java:
##########
@@ -159,6 +159,21 @@ public void ack(Object msgId) {
}
}
+ public void negativeAck(Object msgId) {
Review Comment:
can be rename as `msg`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
